Make Animated modules Flow strict-local (#57738) - #57738
Open
rubennorte wants to merge 8 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113763780. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 28, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
July 28, 2026 17:26
dc1585b to
bd8e76f
Compare
meta-codesync
Bot
changed the title
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
July 29, 2026 10:55
bd8e76f to
bb43b77
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
July 29, 2026 13:44
bb43b77 to
e257912
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
July 29, 2026 15:21
e257912 to
8df7c69
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
July 29, 2026 16:47
8df7c69 to
6c33d68
Compare
rubennorte
force-pushed
the
export-D113763780
branch
from
September 3, 2026 14:42
6c33d68 to
2918103
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 3, 2026 16:30
2918103 to
f4e07dd
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 7, 2026 09:54
f4e07dd to
c358591
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 7, 2026 10:00
c358591 to
c192665
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 8, 2026 10:29
c472b7b to
e44c474
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 8, 2026 10:34
e44c474 to
808c4b7
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
2 times, most recently
from
September 8, 2026 12:27
563a89c to
6a3805d
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 8, 2026 12:33
6a3805d to
e96eddb
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 8, 2026 14:49
e96eddb to
3f07de6
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 8, 2026 17:06
3f07de6 to
8c690c7
Compare
…t#57726) Summary: Pull Request resolved: react#57726 Upgrade the FlatList/SectionList list components, the networking modules (`XMLHttpRequest`, `FormData`, `RCTNetworking`, `convertRequestBody`), and the UIManager modules from `flow` to `flow strict-local`. Public type signatures are preserved exactly, so no consumers need updating; internal `any` and `Object` usages were replaced with accurate types wherever that did not change a public signature. Two public signatures deliberately keep their original loose types behind a scoped `$FlowFixMe[unclear-type]`, because Flow's invariance rules mean any precise annotation would reject existing callers: the `headers` parameters on the `XHRInterceptor` interface (invariant indexers), and `commandArgs` on `UIManager.dispatchViewManagerCommand` (invariant array elements, which would reject callers passing an already-typed array). Changelog: [Internal] Reviewed By: cipolleschi, javache Differential Revision: D113763786
…57730) Summary: Pull Request resolved: react#57730 Upgrade the remaining ReactNative and Core modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763791
Summary: Pull Request resolved: react#57739 Upgrade `deepDiffer`, `codegenNativeCommands`, `Dimensions`, and `ReactNativeTestTools` from `flow` to `flow strict-local`, preserving both public type signatures and runtime behavior. These modules operate on values of arbitrary shape, so the unavoidable `any` and `Function` usages are marked with scoped `$FlowFixMe[unclear-type]` rather than tightened. `Dimensions.addEventListener` deliberately keeps its original `handler: Function` signature. Flow types object properties invariantly, so any precise payload annotation would reject existing subscribers that annotate the payload with their own object shapes, forcing unrelated call sites to change. The generated API snapshot is therefore unchanged for `Dimensions`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763789
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
Summary: Pull Request resolved: react#57734 Upgrade `processTransform` from `flow` to `flow strict-local`, preserving its public type signature. Mechanical violations were fixed accurately; arbitrary-shape internal values are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763784
Summary: Pull Request resolved: react#57737 Upgrade the remaining assorted modules (Touchable pooling, ActionSheetIOS, Alert, LogBox highlight, Text native component, PushNotificationIOS) from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763783
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113763780
branch
from
September 9, 2026 09:38
8c690c7 to
14d678a
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#57738 Upgrade the Animated implementation and node modules from `flow` to `flow strict-local` to enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. Constrain `createAnimatedComponent` to component-only `React.ElementType` values so component props remain inferred without `any`, and regenerate the public API snapshot. Runtime behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763780
rubennorte
force-pushed
the
export-D113763780
branch
from
September 9, 2026 10:33
14d678a to
65dd7b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrade the Animated implementation and node modules from
flowtoflow strict-localto enforce stricter local type checking, replacing loose types with the accurate existing Animated type vocabulary. ConstraincreateAnimatedComponentto component-onlyReact.ElementTypevalues so component props remain inferred withoutany, and regenerate the public API snapshot. Runtime behavior is unchanged.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D113763780